Skip to content

Consider menuAddOn property (+move proposed design into Pending) #1541

Closed

Description

@danbri

Spin-off from discussion in #1288 around menus and menu items: the proposed menuAddOn piece of that design needs further discussion.

http://webschemas.org/menuAddOn

"Additional menu item(s) such as a side dish of salad or side order of fries that can be added to this menu item. Additionally it can be a menu section containing allowed add-on menu items for this menu item."

Per #1288, decision is to move that property into Pending, the rest has rough consensus and is going directly into Core.

/cc @gmackenz

Activity

  1. gmackenz commented on Mar 2, 2017

    @gmackenz
    Contributor
  2. danbri commented on Mar 2, 2017

    @danbri
    ContributorAuthor

    http://webschemas.org/menuAddOn should reflect this change imminently.

  3. DDeering commented on May 4, 2017

    @DDeering

    I know it's pending and I hate to be a stickler about it, but I'm still against using "menuAddOn" as the name of the property. The term implies that something is being added to the menu. But we're not using it to add something to a menu, we're adding something to a menu item. So, wouldn't something like "menuItemAddOn" or "itemAddOn" be a more appropriate name for the property?

    I apologize, @danbri and @gmackenz but I just think that the proposed property name would be confusing to users and wouldn't appropriately reflect its intended use.

  4. thadguidry commented on May 5, 2017

    @thadguidry
    Contributor
  5. DDeering commented on May 22, 2017

    @DDeering

    @danbri Could we move forward with this property but name it "itemAddOn" instead of "menuAddOn"?

  6. gmackenz commented on May 22, 2017

    @gmackenz
    Contributor

    I wonder if 'itemAddOn' isn't just as confusable with 'addOn', I am not opposed to the notion of renaming to menuItemAddOn. That said, I don't think this is ever leaving pending anytime soon.

  7. DDeering commented on May 22, 2017

    @DDeering

    Personally, I think that "itemAddOn" is rather clear and straightforward but I'm open to calling it whatever the majority chooses as long as it's not "menuAddOn" for the reasons I mentioned above.

  8. blerimj commented on Jul 24, 2017

    @blerimj

    How do you solve the problem of MenuItem having multiple size offerings. I.e. Cheese Pizza small , Cheese Pizza Large and the price of toppings (menuItemAddOns) depend on the selection - small or large.

  9. danbri commented on Feb 19, 2019

    @danbri
    ContributorAuthor

    itemAddOn doesn't work well, since it is too generic and this property is all about menus and food

    We are seeing it on a fair number of sites. It is a tiny change left over from the other menu work, let's stick it in the core rather than leaving it dangling.

  10. RichardWallis commented on Apr 10, 2019

    @RichardWallis
    Contributor

    Implemented in release 3.5

  11. gregg-cbs commented on May 11, 2022

    @gregg-cbs

    How do we make use of this? or what can you recommend for add-ons in general? We will have multiple product types from food to electronics all of which will have variants/options/addons of sorts.

    Is menuAddOn ready to be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions